FIX Trigger eagerloading for first() and last() #10875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/fix-eagerloaded-firstlast
branch
from
e9c262b
to
eee426e
Compare
emteknetnz
requested changes
Jul 20, 2023
|
I had assumed |
GuySartorelli
force-pushed
the
pulls/5/fix-eagerloaded-firstlast
branch
from
eee426e
to
02ae5a4
Compare
GuySartorelli
force-pushed
the
pulls/5/fix-eagerloaded-firstlast
branch
from
02ae5a4
to
df2a02e
Compare
emteknetnz
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic is directly pulled from
SQLSelect::firstRow()andSQLSelect::lastRow()which is was ultimately was powering these methods - tracing those, you can see that this limited query (limit 1) was always being run, and the result (which was necessarily an array of size one) was returned from the database - and then just the first and last rows respectively were pulled out from there in PHP.So the logic is unchanged, I'm just pulling it up to this level so we can also trigger eager loading - and only trigger it once. i.e. calling
first()thenlast()and then iterating over the same list won't trigger multiple db queries.Issue